-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try adding "Stewart", a light blogging theme with a sidebar #4369
Conversation
I kept the left sidebar content really simple for now, so that this could theoretically work as a universal theme pretty easily. It just contains a navigation block (which we already have working for Quadrat for example), and the social links block. (Do we have a way to make a social nav work in both classic themes and block themes?). That said, to make this a truly customizable universal sidebar theme we'd probably need to figure out a way to let non-FSE folks customize the sidebar with widgets. 😬 |
Let me know when you need a beta tester. I'll switch up my blog on WordPress.com. I have to use this theme now. :) |
I wonder if we can use a "widget area" block to achieve this. |
Just a heads up that I've gone in and pushed a few commits to start separating this out from Blockbase. It should work just fine as a standalone block theme now, though there are some spacing inconsistencies and likely a few unnecessary theme.json styles. |
Known issues:
|
I'm concerned about doing this in CSS as it means that this block behaves differently to other column blocks. The feedback we've had in the past about using CSS is "CSS should not be used for structural changes". |
We should explore adding our Google font stack to this... |
Yeah, I agree. But I think this is mostly harmless? I don't feel strongly, so I'm happy to strip it out and let the editor do its wrong thing for now. If the columns are 50/50 on tablets for now, I don't consider it a blocker. (EDIT: Reverted for now in 3fa0b28)
Yeah, probably through a plugin and/or some dotcom functionality though, so it can be re-used. Doesn't make sense to add that into every single theme. |
This theme is completely crashing for me right now. Can't figure out why. No errors just a completely empty html payload. Just this theme. Not sure what's up. |
I ran into it; requested at WordPress/gutenberg#34752 with some short-term workarounds for it. |
That's odd — @pbking what WP + Gutenberg version are you running? It's working fine for me w/Gutenberg 12.1 & WP 5.8.2. |
I was using Gutenberg 12.0.1 and WP 5.8.2 Regardless it's working for me now. |
Do you folks think this is in a decent-enough place where we can merge it in and get it up on dotcom for testing? |
@scruffian I've adjusted what I can, but some of this I think is just an issue with Global Styles. You used to be able to edit the "Primary" color, but that's not possible anymore (unless I'm missing something?). |
Yeah that's what I was noticing too. Seems like we might need to open a Gutenberg issue for that as it's going to be a bit of a blocker... |
@scruffian It's still there actually, I think we both actually just overlooked this control: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case I say LGTM
Awesome. I'll leave this up to you folks to merge and deploy. 👍 |
This is a light Blockbase spinoff for blogging that includes a left sidebar. Still needs a little light polish (and a bunch of testing?), but it seems to work generally well as a block-based theme given the small amount of effort I've put into it. It's named "Stewart", after @ianstewart (who asked us to make a blogging theme with a sidebar).
Screenshot