Blockbase: make 404 into a php template so it can be translated #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
commented
Jul 26, 2021
| @@ -198,6 +198,9 @@ | |||
| } | |||
| } | |||
| }, | |||
| "layout": { | |||
| "contentSize": "620px" | |||
There was a problem hiding this comment.
We should probably also look into making it so the layout key generates a CSS variable, because this is redundant.
There was a problem hiding this comment.
Couldn't find anything so opened this: WordPress/gutenberg#33705
pbking
reviewed
Jul 27, 2021
| @@ -3,10 +3,6 @@ | |||
| <!-- wp:group {"layout":{"inherit":true}, "tagName":"main"} --> | |||
| <main class="wp-block-group"> | |||
|
|
|||
| <!-- wp:heading --> | |||
| <h2>Results:</h2> | |||
There was a problem hiding this comment.
Should we do the same for blockbase? That would make all 4 blockbase themes i11n-ready.
pbking
approved these changes
Jul 27, 2021
MaggieCabrera
approved these changes
Jul 27, 2021
Yeah we've only created one for Quadrat so far, guessing we should do one for Blockbase too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This makes it so Blockbase and its children's 404 template is php-based so it can be translated. I
I could not just add a 404.php template to Quadrat. Blockbase's 404.html template would win in the template resolution logic. So I had to replace Blockbase's template with a php-based one to get this approach to work.
Related issue(s):
#3653