Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libre 2: Fix Centre Alignment of Images & Captions #411

Merged
merged 1 commit into from
Jan 1, 2019

Conversation

Aurorum
Copy link
Contributor

@Aurorum Aurorum commented Dec 6, 2018

Changes proposed in this Pull Request:

#408 doesn't seem to work like intended, and it seems I can't modify that PR as captions aren't shown when trying to do so. Therefore, after trying to look for an alternative, I've created a new PR to try and solve the issue of images not aligning when using the Image Block on the Libre 2 theme.

I'm not too sure if this is the most effective way at solving this problem, but I'm hoping it does work.

Before:

gfsdgfsdfgsfgsd

After:

gfsfgddfgsgdf

(cc @laurelfulford)

Related issue(s): #404

@laurelfulford
Copy link
Contributor

Thanks for the patch, @torres126!

I'm not sure why, but I'm getting some weirdness when I apply it -- like the centre aligned images aren't centred, and the caption is aligned centre when it shouldn't be:

image

I think a lot has to do with the figure element styles already in in blocks.css --- too many :not()s to override well!

I'm going to make a couple changes to your updates locally, to tidy up the figure stuff, and commit!

@laurelfulford laurelfulford merged commit a404eed into Automattic:master Jan 1, 2019
@Aurorum
Copy link
Contributor Author

Aurorum commented Jan 2, 2019

Hm, that's odd, not sure why that happened. Thanks for fixing it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants