Quadrat: Add Join pattern #3745
Conversation
| } | ||
| } | ||
| endif; | ||
|
|
||
| add_action( 'after_setup_theme', 'quadrat_register_block_patterns', 12 ); | ||
| add_action( 'init', 'quadrat_register_block_patterns' ); |
There was a problem hiding this comment.
This change is needed so that the blocks are registered when we register the patterns. The problem is it moves Quadrat to the bottom of the patterns list drop down.
There was a problem hiding this comment.
Hmm I see. I wonder if we can re-order the list somehow?
| } | ||
| } | ||
| endif; | ||
|
|
||
| add_action( 'after_setup_theme', 'quadrat_register_block_patterns', 12 ); | ||
| add_action( 'init', 'quadrat_register_block_patterns' ); |
There was a problem hiding this comment.
Hmm I see. I wonder if we can re-order the list somehow?
scruffian
force-pushed
the
add/join-pattern
branch
4 times, most recently
from
8f7c006 to
f3be992
Compare
|
We can get it higher in the list: @kjellr do you have a preference for where this should go? |
scruffian
force-pushed
the
add/join-pattern
branch
from
9d1944c to
628f691
Compare
quadrat/sass/theme.scss
Outdated
|
|
||
| .subscription-column { | ||
| text-align: right; | ||
| } |
There was a problem hiding this comment.
should this be inside this folder?
Theme patterns generally show up at the top of the list, so if we can do that I think that's the best route. (I haven't tested this PR yet, so it's possible you're already doing that now). |
| @@ -28,15 +27,18 @@ function quadrat_register_block_patterns() { | |||
| 'listen-to-the-podcast', | |||
| ); | |||
|
|
|||
| if ( class_exists( 'WP_Block_Type_Registry' ) && \WP_Block_Type_Registry::get_instance()->is_registered( 'jetpack/subscriptions' ) ) { | |||
There was a problem hiding this comment.
We should update the wpcom-only patterns in Blank Canvas to use this method, rather than loading them in their own separate wpcom.php file.
Changes proposed in this Pull Request:
Adds a "Join" pattern.
To test you need Jetpack installed and running on a custom domain, to make the subscription block work. It might be easier to test on a simple site.
Note: The button / input on the subscription form doesn't match the theme. This is because of this issue:Automattic/jetpack#17590
It would also be really good to get this done so we don't need the custom CSS: WordPress/gutenberg#31459
Related issue(s):
#3642