Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libre 2: Smaller images in image blocks can't be aligned centre #404

Closed
laurelfulford opened this issue Nov 29, 2018 · 3 comments · Fixed by #467
Closed

Libre 2: Smaller images in image blocks can't be aligned centre #404

laurelfulford opened this issue Nov 29, 2018 · 3 comments · Fixed by #467
Labels
Support [Type] Bug Something isn't working
Milestone

Comments

@laurelfulford
Copy link
Contributor

Moved from here: Automattic/wp-calypso#28756 (comment)

When you centre a small image block, it doesn't actually display as centred on the front-end. The issue looks to be related to these styles here setting the margins to 0, but it needs investigating:

https://github.com/Automattic/themes/blob/master/libre-2/css/blocks.css#L78-L83

Steps to replicate

  1. Using a site that has Libre 2, add an image block.
  2. Add an image to that block, and if it's not small, scale it down.
  3. Centre the block.

Result

The block is centred in the editor, but not on the front-end.

@selectedselections
Copy link

Hi there! This was reported by another user here zd-1633145
I was also able to reproduce the issue on my own test site.

@laurelfulford
Copy link
Contributor Author

This was committed in r52700-wpcom-themes.

@laurelfulford
Copy link
Contributor Author

Followed up on the forum thread.

@selectedselections it looks like that ZD ticket is now closed, so I can't leave a comment there. Could you please follow up with the user? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants