Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadrat: Block Patterns #3642

Closed
8 tasks done
jffng opened this issue Apr 12, 2021 · 5 comments
Closed
8 tasks done

Quadrat: Block Patterns #3642

jffng opened this issue Apr 12, 2021 · 5 comments

Comments

@jffng jffng added this to the Quadrat milestone Apr 12, 2021
@jffng
Copy link
Contributor Author

jffng commented Apr 12, 2021

@beafialho did you imagine any other aspects of the theme to be bundled as a block pattern?

@beafialho
Copy link
Collaborator

I think these are all the block patterns we had thought for the theme. We could probably remove the one with Photography in "Text + Image Cover CTA" and leave only the one with Illustration, what do you think @kjellr?

@kjellr
Copy link
Contributor

kjellr commented Apr 13, 2021

Yeah, I agree, we should just the one with the illustration there.

I think the audio player one might not be possible yet, but we can give it a try.

@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Apr 26, 2021

For the Alternating Promos block pattern:

We can't make it a Query Block pattern because:

  • Alternating layouts… this is currently possible by using multiple query blocks with offsets. I guess we can do this, but it’s a little weird.
  • Those “Learn more” buttons. I guess those are technically “Read more” links, but they appear as buttons.

They can be made using Latest Posts / Jetpack Blog Posts and if we can't use buttons on those either we can ignore them (the buttons) for the time being

Related GB issue about the read more link as a button: WordPress/gutenberg#25450

@scruffian
Copy link
Member

These are all done, I think we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants