Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore using install_swift_dependencies and SwiftPM cache #2471

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Nov 21, 2024

Restore using install_swift_dependencies and SwiftPM cache

We disabled this because of an issue with package resolution, see #1990

Since then, a fix has been implemented in the command, see Automattic/a8c-ci-toolkit-buildkite-plugin#105 so we can re-enable it.

To test

See screenshots below of green CI with command running and correct packages resolution

image

image

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary. – N.A.
  • I have considered adding unit tests for my changes. – N.A.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics. – N.A.

We disabled this because of an issue with package resolution, see
#1990

Since then, a fix has been implemented in the command, see
Automattic/a8c-ci-toolkit-buildkite-plugin#105
so we can re-enable it.
@mokagio mokagio requested a review from a team as a code owner November 21, 2024 07:24
@mokagio mokagio requested review from bjtitus and removed request for a team November 21, 2024 07:24
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 21, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.78. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@mokagio mokagio added the [Type] Tooling Issues related to tooling: build tools, ruby, scripts, etc. label Nov 21, 2024
@mokagio mokagio requested a review from a team November 21, 2024 08:36
@mokagio mokagio added this to the 7.78 milestone Nov 21, 2024
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@AliSoftware AliSoftware merged commit dc47205 into trunk Nov 21, 2024
6 of 8 checks passed
@AliSoftware AliSoftware deleted the mokagio/restore-install_swift_dependencies branch November 21, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Tooling Issues related to tooling: build tools, ruby, scripts, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants