Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get php linting working and fix errors #1949

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR gets PHP linting working, and lines up the linting settings closer to Newspack Blocks (including switching the linting from WordPress-Core -- left over from the theme's original forking of Twenty Nineteen -- to just WordPress). It also fixes any errors that came out of running composer lint.

There are still a number of exclusions in the phpcs.xml.dist that are unique to the theme, but removing them and making the subsequent fixes turned into a lot of changes for one PR, so I think that might be best to handle after this is merged.

Closes # .

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant