chore: get php linting working and fix errors #1949
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR gets PHP linting working, and lines up the linting settings closer to Newspack Blocks (including switching the linting from WordPress-Core -- left over from the theme's original forking of Twenty Nineteen -- to just WordPress). It also fixes any errors that came out of running
composer lint
.There are still a number of exclusions in the phpcs.xml.dist that are unique to the theme, but removing them and making the subsequent fixes turned into a lot of changes for one PR, so I think that might be best to handle after this is merged.
Closes # .
How to test the changes in this Pull Request:
Other information: