Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: featured image support for inline popups #925

Closed
wants to merge 2 commits into from

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Jul 28, 2022

All Submissions:

Changes proposed in this Pull Request:

Building on #924, adds featured image support for inline popups, too.

How to test the changes in this Pull Request:

  1. Switch Newspack Theme to feat/prompt-styles branch (feat: remove prompt-related styles newspack-theme#1887)
  2. Create a new prompt, observe a featured image can be added
  3. View the frontend, observe the featured image is displayed
  4. Observe the featured image is centred in a 200px high element above prompt content

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Base automatically changed from feat/prompt-featured-image to master July 29, 2022 15:18
@adekbadek adekbadek force-pushed the feat/universal-featured-image branch from 692936e to 35f7342 Compare July 29, 2022 15:21
@dkoo
Copy link
Contributor

dkoo commented Sep 28, 2022

Looks like this got superseded by #924

@dkoo dkoo closed this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants