fix: hide cpt from menu

[miguelpeixe]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This is a fix for Automattic/newspack-plugin#3549.

Popups post type is already not shown in the menu, but without the explicit flag, WP will override (more specifically here) the parent_file filter we're using to activate a custom menu when creating a new prompt:

How to test the changes in this Pull Request:

1. Checkout on feat(ia): audience campaigns newspack-plugin#3549 and while on trunk, navigate to create a new segment (/wp-admin/post-new.php?post_type=newspack_popups_cpt)
2. Confirm no menu items are active
3. Checkout this branch, refresh the page and confirm the "Audience -> Campaigns" menu is active

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

Not strictly related but similar, so I'll mention here: when in the "create new segment" screen, the tabs lose focus as well.

[miguelpeixe]

Thanks, @dkoo! It seems like this is the current behavior in trunk as well, I'll see if we can fix this without having to change too much of the existing tabbed navigation structure.

[github-actions]

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

[miguelpeixe]

@dkoo, fixed the Segments tab in Automattic/newspack-plugin@7e515b6

[matticbot]

🎉 This PR is included in version 3.1.5-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.1.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀