Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove inline-block display type from radio-control option #1356

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: remove inline-block display type from radio-control option #1356

merged 1 commit into from
Oct 31, 2024

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1206274567818686/1208604801170731/f

Looks like the display type for radio control option has been set to grid in WP 6.7. This PR removes our display type of inline-block so as not to interfere with the new grid styling.

Before:
Screenshot 2024-10-31 at 11 17 57

After:
Screenshot 2024-10-31 at 13 06 07

How to test the changes in this Pull Request:

  1. On WP 6.6 edit any prompt via Newspack > Campaigns
  2. In the editor look for the prompt type radio inputs. There will be no margin as pictured in the Before screenshot above.
  3. Update to 6.7-RC2 and view the editor for the same prompt
  4. The radio inputs should have proper right margin as pictured in the After screenshot above

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle requested a review from a team as a code owner October 31, 2024 17:08
laurelfulford
laurelfulford approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I also double-checked this change with 6.6.2 (out of absolute paranoia!!) and didn't spot any issues. 🚢

@chickenn00dle chickenn00dle merged commit d2b0f21 into trunk Oct 31, 2024
10 checks passed
@chickenn00dle chickenn00dle deleted the fix/wp-6.7-prompt-type-radio-styles branch October 31, 2024 20:17
matticbot pushed a commit that referenced this pull request Nov 6, 2024
@semantic-release-bot
chore(release): 3.1.1-alpha.1 [skip ci]
5b1a0bb 
## [3.1.1-alpha.1](v3.1.0...v3.1.1-alpha.1) (2024-11-06)

### Bug Fixes

* prevent extra scrollbar ([#1354](#1354)) ([5138051](5138051))
* remove inline-block display type ([#1356](#1356)) ([d2b0f21](d2b0f21))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 11, 2024
@semantic-release-bot
chore(release): 3.1.1 [skip ci]
50c55c7 
## [3.1.1](v3.1.0...v3.1.1) (2024-11-11)

### Bug Fixes

* prevent extra scrollbar ([#1354](#1354)) ([5138051](5138051))
* remove inline-block display type ([#1356](#1356)) ([d2b0f21](d2b0f21))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved WP 6.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chickenn00dle @matticbot @laurelfulford