fix(segmentation): handle bad MC API key #1343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Adds handling of invalid Mailchimp API key.
Submitting as a hotfix, because the issue triggers PHP Fatals, which pollute our logs.
How to test the changes in this Pull Request:
release
, update the value of thenewspack_mailchimp_api_key
option to an empty stringwp eval "\Newspack_Popups_Segmentation::reader_logged_in(111, []);"
, observe a PHP Fatal is loggedOther information: