fix: use loose type comparison for list__in and list__not_in

[dkoo]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Currently list__in and list__not_in criteria matching functions use includes (which enforces strict type comparison) to compare segmentation criteria values with reader data values. However, we've seen varying behavior across different sites where IDs get stored in reader data as strings instead of integers, which causes these matching functions to fail.

This change allows the type comparison to be loose using ==, which should solve the issue.

How to test the changes in this Pull Request:

Unit tests should prove this, but to test functionally:

1. On release, create a segment and choose a product in the "Does not have active subscription" option. Publish a prompt to that segment.
2. Register a reader account and purchase the required subscription product. Visit at least a couple of pages to ensure that the reader data updates in localStorage and confirm that you don't see the prompt you created in step 1.
3. In dev tools, go to Application > Storage, unfurl "Local storage", and click on your dev site's URL. Note the np_reader_1_active_subscriptions value. If it's an array containing an integer click the value to edit it to a string with the same number, like so:

4. Visit a couple more pages and confirm that you start seeing the prompt you created in step 1 (because your reader data value is "275" and the segment expects 275).
5. Check out this branch, visit another page and confirm you no longer see the prompt.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1207679631535856

[matticbot]

🎉 This PR is included in version 2.34.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀