fix: prevent prompt expiration with invalid expiration date #1318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes a regression introduced in #1305. For some reason, some posts did get
expiration_date
with empty value assigned. Unfortunately, there's no way to fix these (re-publish), since we can't know which prompts were supposed to be published or not in the first place.How to test the changes in this Pull Request:
release
, assign empty value to a published promptexpiration_date
metawp cron event run newspack_popups_check_expiry
, observe the prompt has been reverted to draftexpiration_date
is not reverted to draftOther information: