Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update above-header hook used by plugin #1302

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented May 3, 2024

All Submissions:

Changes proposed in this Pull Request:

This PR updates the before_header used by the plugin for the more standard wp_body_open, which is already included in our classic theme and that appears by default in block themes.

This fixes a couple small issues with this plugin + block themes, and hopefully doesn't cause any weirdness with our existing theme.

I think this is a pretty harmless change -- the two hooks are stacked in our current theme -- but definitely would appreciate an eye to potential issues!

Closes 1203518336360239-as-1203518336360246, 1203518336360239-as-1203518336360244

How to test the changes in this Pull Request:

  1. Using a block theme (like ours), and starting on trunk, set up an above header prompt.
  2. View on the front end and note it doesn't work.
  3. Set up a popup prompt.
  4. View on the front-end and note that while it works, you can't close it.
  5. Apply this PR.
  6. Repeat steps 1-4 and confirm that both are now working.
  7. Switch to our classic theme, and repeat steps 1-4 and confirm they're still okay.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't imagine this would cause any issues!

@laurelfulford
Copy link
Contributor Author

Thanks @dkoo! 🙌

@laurelfulford laurelfulford merged commit fe756a4 into trunk May 8, 2024
7 checks passed
@laurelfulford laurelfulford deleted the fix/update-header-hook branch May 8, 2024 15:10
matticbot pushed a commit that referenced this pull request May 20, 2024
# [2.32.0-alpha.1](v2.31.3...v2.32.0-alpha.1) (2024-05-20)

### Bug Fixes

* improved attribute handling ([f3eb1ae](f3eb1ae))

### Features

* update header hook to a more standard one ([#1302](#1302)) ([fe756a4](fe756a4))

### Reverts

* automated file updates [skip ci] ([b59282c](b59282c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.32.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 28, 2024
# [2.32.0](v2.31.3...v2.32.0) (2024-05-28)

### Bug Fixes

* improved attribute handling ([f3eb1ae](f3eb1ae))

### Features

* update header hook to a more standard one ([#1302](#1302)) ([fe756a4](fe756a4))

### Reverts

* automated file updates [skip ci] ([b59282c](b59282c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants