Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ras overlays #1233

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat: implement ras overlays #1233

merged 1 commit into from
Oct 19, 2023

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Implements RAS overlays as proposed in Automattic/newspack-plugin#2708

How to test the changes in this Pull Request:

  1. Checkout this branch, feat(ras): overlay management for content gate refresh newspack-plugin#2708, and add the following code to line 20 of src/view/segmentation.js:
		ras.on( 'overlay', ev => {
			console.log( ev.detail );
		} );
  1. Create an overlay prompt to render for everyone and on every page view
  2. Visit the front-end and open devtools
  3. Wait until the prompt renders and confirm the array containing an overlay ID is logged
  4. Close the prompt and confirm the overlays array is again logged and empty

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Oct 18, 2023
@miguelpeixe miguelpeixe requested a review from a team as a code owner October 18, 2023 15:35
@miguelpeixe miguelpeixe merged commit 6c86cd3 into master Oct 19, 2023
2 checks passed
@miguelpeixe miguelpeixe deleted the feat/ras-overlays branch October 19, 2023 13:33
matticbot pushed a commit that referenced this pull request Oct 20, 2023
# [2.25.0-alpha.2](v2.25.0-alpha.1...v2.25.0-alpha.2) (2023-10-20)

### Features

* implement ras overlays ([#1233](#1233)) ([6c86cd3](6c86cd3))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.25.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 31, 2023
# [2.25.0](v2.24.0...v2.25.0) (2023-10-31)

### Bug Fixes

* deduplication strategy for Homepage Posts block ([#1228](#1228)) ([bbb952d](bbb952d))

### Features

* implement ras overlays ([#1233](#1233)) ([6c86cd3](6c86cd3))
* remove is_non_interactive method ([adabea2](adabea2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants