Skip to content

Commit

Permalink
fix: position calculation for inline popups
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelpeixe committed Oct 4, 2024
1 parent aaea95d commit 3bc2b4a
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions includes/class-newspack-popups-inserter.php
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,18 @@ public static function get_block_content( $block ) {
return $block_content;
}

/**
* Get the length of a given block.
*
* @param array $block A block.
*
* @return int
*/
private static function get_block_length( $block ) {
$block_content = self::get_block_content( $block );
return strlen( wp_strip_all_tags( $block_content ) );
}

/**
* Insert popups in a post content.
*
Expand Down Expand Up @@ -349,8 +361,7 @@ function ( $block_groups, $block ) use ( &$block_index, $parsed_blocks, $max_ind
// Give length-ignored blocks a length of 1 so that prompts at 0% can still be inserted before them.
$total_length++;
} else {
$block_content = self::get_block_content( $block );
$total_length += strlen( wp_strip_all_tags( $block_content ) );
$total_length += self::get_block_length( $block );
}
}

Expand Down Expand Up @@ -385,7 +396,7 @@ function ( $block_groups, $block ) use ( &$block_index, $parsed_blocks, $max_ind
// Give length-ignored blocks a length of 1 so that prompts at 0% can still be inserted before them.
$pos++;
} else {
$pos += strlen( wp_strip_all_tags( $block['innerHTML'] ) );
$pos += self::get_block_length( $block );
}
}

Expand Down

0 comments on commit 3bc2b4a

Please sign in to comment.