[HOLD] feat(popups): default segments UI

[dkoo]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

UI for Automattic/newspack-popups#809.

How to test the changes in this Pull Request:

See testing instructions in Automattic/newspack-popups#809.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[adekbadek]

This would use @thomasguillot 's input, but I think there's a problem with CTA hierarchy here:

The "Generate…" message should be more prominent IMO – perhaps centered and framed?

[thomasguillot]

I agree with @adekbadek, there are too many Primary buttons.

[dkoo]

I like the proposed design a lot better than my single button! One thing to note, there's discussion in Automattic/newspack-popups#809 about automatically triggering the default segment creation if the site lacks any active prompts and segments, so that would mean the proposed UI would only really be shown for sites that are running active campaigns but haven't created any segments.

For sites that may have active campaigns and segments already, how should the button be presented? As a secondary button next to the "Add New Segment" button? I thought about putting a popover menu button next to it, but those components don't quite work in this context, outside of an action card component.

[dkoo]

@adekbadek @thomasguillot I pushed some changes in 18cbc23 to update the design as proposed. If we decide to auto-generate these default segments for new sites, I'll make that change here.

[thomasguillot]

@dkoo I pushed a few more visual changes (20254be)

[thomasguillot]

Oops fixed: 18c5ced

[dkoo]

It's been decided to automatically generate the default segments on WP init rather than via the UI as long as the site has no pre-existing segments. This means that @thomasguillot's lovely new UI will only ever be seen as a fallback in case this creation fails for whatever reason.

174f966 adds an additional check and error message if the required Campaigns config file is missing—I noticed that on non-Atomic sites, there's no visual warning in the wizard UI that we're missing the file and can't use Campaigns features.

[adekbadek]

Note: changes here depend on Automattic/newspack-popups#809, these should be merged simultaneously.

[dkoo]

Note to @thomasguillot: after some discussion we've decided we'd like to build this out into a more guided onboarding/wizard experience to guide users toward one of several sets of default segments, based on their input. @aschweigert will work on a suggested flow for this, but let's hold these changes until we can flesh that out a bit more.

[dkoo]

Closing this as we've decided to go in a different direction for establishing defaults.