fix: remove animation fill mode for modals #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
added
the
[Status] Needs Review
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Feb 24, 2022
# [1.78.0-alpha.1](v1.77.1...v1.78.0-alpha.1) (2022-02-24) ### Bug Fixes * initial theme mods setting ([#1500](#1500)) ([2d3de6b](2d3de6b)), closes [#1093](#1093) * remove animation fill mode for modals ([#1517](#1517)) ([a5c0459](a5c0459)) * **setup-wizard:** hide navigation on welcome screen ([a6fad4e](a6fad4e)) ### Features * **ad-units:** move edit/archive links to popover ([#1505](#1505)) ([5177fe6](5177fe6)) * **stripe:** donate flow; location code ([#1483](#1483)) ([8cd28f9](8cd28f9))
|
🎉 This PR is included in version 1.78.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 8, 2022
# [1.78.0](v1.77.3...v1.78.0) (2022-03-08) ### Bug Fixes * initial theme mods setting ([#1500](#1500)) ([2d3de6b](2d3de6b)), closes [#1093](#1093) * remove animation fill mode for modals ([#1517](#1517)) ([a5c0459](a5c0459)) * **setup-wizard:** hide navigation on welcome screen ([a6fad4e](a6fad4e)) * stripe data setting ([ceec544](ceec544)) ### Features * **ad-units:** move edit/archive links to popover ([#1505](#1505)) ([5177fe6](5177fe6)) * **stripe:** donate flow; location code ([#1483](#1483)) ([8cd28f9](8cd28f9))
|
🎉 This PR is included in version 1.78.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This is a temporary fix until WordPress/gutenberg#38716 is not reviewed/released.
Fixes the positioning of Popovers inside Modals for Chrome and Safari.
With the animation fill mode set to
forwards, the final step setstransformto a defined value. This makesposition: fixedchild elements position from the Modal's edge instead of the viewport.More on
positionand containing blocks: https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block#identifying_the_containing_blockHow to test the changes in this Pull Request:
overflow: hiddenof Modal container)Other information: