feat(gam): add filter for ad config data in gtag #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
pushed a commit
that referenced
this pull request
Jan 14, 2025
# [3.3.0](v3.2.2...v3.3.0) (2025-01-14) ### Features * **gam:** add filter for ad config data in gtag ([#933](#933)) ([32e931e](32e931e))
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p1733840865403849-slack-C07UT1REAGJ
Adds a filter to GAM's script so the ad config data can be modified. This is mostly useful for Google MCM support, which allows a "parent" network code to manage the inventory for a "child" GAM account. See more on #170.
Eventually, we should implement the solution proposed in #170 (comment)
Testing
With GAM configured, check out this branch and confirm that the ads are rendered as expected. The addition of the filter shouldn't have any impact on GAM ad rendering.