-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update CSS selector for tabs to work outside of media kit #931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dkoo! I noticed that, too, but I honestly wasn't sure if it was intentional 😂 I've fixed the alignment -- can you please retest it as is, and inside of a group block with a background? The padding added to the tabs block in that situation caused the label to be pushed too far right as well, and this should now fix both! |
Hey @laurelfulford, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
🎉 This PR is included in version 3.2.3-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.3.2-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.3.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The Tabs block was added to the Ads plugin as part of the Media Kit.
This PR changes a selector in the Media Kit styles, to make sure the tabs block looks ok outside of the Media Kit patterns.
Steps to test
npm run build
.