Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update CSS selector for tabs to work outside of media kit #931

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

laurelfulford
Copy link
Contributor

The Tabs block was added to the Ads plugin as part of the Media Kit.

This PR changes a selector in the Media Kit styles, to make sure the tabs block looks ok outside of the Media Kit patterns.

Steps to test

  1. Add a tabs block to a regular post or page, and publish.
  2. Note the appearance on the front-end -- it doesn't match the editor:

CleanShot 2025-01-08 at 10 50 48

CleanShot 2025-01-08 at 10 49 43

  1. Apply this PR and run npm run build.
  2. Confirm that the tabs block matches in the editor and on the front-end:

CleanShot 2025-01-08 at 10 51 12

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better, but I notice there's a display bug when adding a new tab header. The header text is duplicated:

Screenshot 2025-01-09 at 4 01 29 PM

@laurelfulford
Copy link
Contributor Author

Thanks @dkoo! I noticed that, too, but I honestly wasn't sure if it was intentional 😂

I've fixed the alignment -- can you please retest it as is, and inside of a group block with a background? The padding added to the tabs block in that situation caused the label to be pushed too far right as well, and this should now fix both!

CleanShot 2025-01-10 at 11 06 57

@laurelfulford laurelfulford requested a review from dkoo January 10, 2025 19:15
@laurelfulford laurelfulford merged commit 5b58b73 into trunk Jan 10, 2025
7 checks passed
Copy link

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.2.3-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.3.2-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants