-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(media-kit): add media kit (from publisher-media-kit plugin) #894
Conversation
It works well. I left the media-kit plugin active on purpose to see if there would be any conflict, looks ok.
I had to manually delete the page. Overall it looks good, my only question is that there is no way for an existing user of the plugin to start using this feature unless they deactivate and activate the plugin. I'm not sure I have all the context, but is that ok? Don't we want to add a button somewhere to create the page? |
That's a great remark, indeed we should not require the plugin to be re-activated. However, in our case the migration will be one by one, assisted by our team, so we have no immediate need for a UI. Instead, I've added a CLI command in 7d259fc. I've updated the testing instructions. |
# [3.1.0-alpha.1](v3.0.2...v3.1.0-alpha.1) (2024-08-30) ### Features * **media-kit:** add media kit (from publisher-media-kit plugin) ([#894](#894)) ([8c46acf](8c46acf))
🎉 This PR is included in version 3.1.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [3.1.0](v3.0.2...v3.1.0) (2024-10-08) ### Features * **media-kit:** add media kit (from publisher-media-kit plugin) ([#894](#894)) ([8c46acf](8c46acf))
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Incorporates a Media Kit page functionality, adapted from the https://github.com/10up/publisher-media-kit/ plugin:
How to test the changes in this Pull Request:
publisher-media-kit
plugin is active, deactivate it and ensure the media kit page andpmk-page
option are deletedwp newspack-ads create-media-kit-page
to create the page, observe the command outputs the created post IDOther information: