Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter for settings access #789

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: filter for settings access #789

merged 1 commit into from
Jan 15, 2024

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Adds filtering of admin panel access. This will be used by upcoming changes in the Newspack Plugin, which will introduce granular capabilities management.

How to test the changes in this Pull Request:

  1. There should be no functional changes for end users, this is a backend feature. Verify that Newspack Advertising wizard can still be accessed as an admin* user

* a user with manage_options capability

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek requested a review from a team as a code owner January 10, 2024 13:58
@chickenn00dle chickenn00dle self-assigned this Jan 12, 2024
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adekbadek adekbadek merged commit ca410c5 into master Jan 15, 2024
7 checks passed
@adekbadek adekbadek deleted the feat/permissions branch January 15, 2024 12:34
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.46.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.46.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants