-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6503): Add Int32 to SchemaType #15054
Open
aditi-khare-mongoDB
wants to merge
17
commits into
Automattic:master
Choose a base branch
from
mongodb-js:NODE-6503/int32-schemaType
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(NODE-6503): Add Int32 to SchemaType #15054
aditi-khare-mongoDB
wants to merge
17
commits into
Automattic:master
from
mongodb-js:NODE-6503/int32-schemaType
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've reopened the PR against the fork, here. Here's a link to you open comment thread, so we can follow-up on it. |
vkarpov15
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If it's ok with you, I will merge this into the 8.9 branch so we can merge it with the rest of the 8.9.0 release.
That works for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the one opened on the mongodb fork, Val's initial round of feedback has been addressed.
Summary
Motivation
Support a 32-bit integer type in mongoose for compatibility with CSFLE/QE. The current
Number
schema type can result in either Int32, Int64, or Doubles that are inserted into the database using type inference but CSFLE and QE require exact BSON types in schemas.Summary of Changes
SchemaType
Int32
, which has the following behavior:cast
method throws when provided aNaN
$type: int
or$type: number
, but NOT$type: double
Example