-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: ensure playsInline
attribute conforms when falling back to core Video block
#36030
revert: ensure playsInline
attribute conforms when falling back to core Video block
#36030
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Fixes a regression that prevents the "plays inline" setting working for Atomic sites with VideoPress enabled on the web.
Proposed changes:
playsInline
attribute conforms when falling back to core Video block #35981 have been reverted to prevent a regression on the web.Other information:
Jetpack product discussion
#35981 (comment)
Does this pull request change what data or activity we track or use?
No, it does not.
Testing instructions: