-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown block: add support for footnotes. #30149
Conversation
Fixes #11849 Also see #18035 and #11881. This involves bringing in a new dependency to the Jetpack plugin: - https://github.com/markdown-it/markdown-it-footnote - MIT License
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run
to get started. More details: p9dueE-5Nn-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #11849
Proposed changes:
Jetpack ships with 2 flavors of Markdown:
jetpack/projects/plugins/jetpack/modules/markdown.php
Lines 3 to 4 in 3a3c4ad
This PR is about the latter. It makes no changes to the classic Markdown feature available in the classic editor. This classic Markdown feature already supports footnotes.
The block, however, did not support footnotes, as it relies on a package (
markdown-it
) that does not support footnotes out of the box. There, you must use plugins to enable extra features.In this PR, I'm bringing in a new dependency to the Jetpack plugin, to add support for footnotes:
Other information:
Jetpack product discussion
See #18035 and #11881.
Does this pull request change what data or activity we track or use?
Testing instructions:
Example content