Remove recurring-payments button color

[dsas]

Fixes #24768

Changes proposed in this Pull Request:

The Payments Button button color was hardcoded to white (#fff). The
button itself's color could be overriden by using the editor controls
but the outline style just meant the button was invisible - white on
white backgrounds.

This has been fixed by removing the rule completely - I can't see why
it exists. Another approach would have been to use the currentColor
pseudo-color.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Create a site with a paid WPcom (or JP Security/Complete) plan using the 2022 theme
• Add a new post and insert a payment button
• Complete Stripe set-up
• Go back to the post and insert a second payment button, selecting the 'outline' style from the right hand bar
• The button disappear
• Publish and view the page
• The second button should be invisible
• Apply this patch
• Refresh the page, both buttons should be visible
• Refresh the editor, both buttons should be visible there too.

before	after

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello dsas! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D82951-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: July 5, 2022.
• Scheduled code freeze: June 28, 2022.

[dsas]

@aaronrobertshaw added you as a reviewer on the off-chance you can remember if there was a set of specific circumstances leading to this change two years ago. It might just be that lots of other stuff has changed since :)

[aaronrobertshaw]

Thanks for the ping @dsas.

From my vague memory, this was related to maintaining the existing styling of the button when it was switched to an inner block in #15915. I also have a recollection that at the time there were some catches around maintaining the old SubmitButton's fallback colors and AMP styling for what is now the legacy AMP theme.

As you note, I can't see why it's still required unless it is only for old deprecated recurring-payment button's markup.

It's been a long time since I've waded into Jetpack waters but this PR is testing as advertised for me. I'd prefer to leave final approval to the Jetpack crew in case my lack of familiarity with Jetpack these days has caused me to overlook something.

[rcrdortiz]

Tests well.

[github-actions]

Great news! One last step: head over to your WordPress.com diff, D82951-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

[dsas]

Deployed r247796-wpcom