-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
widget-conditions: fix regression introduced in #22414 #22457
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
…238742-wpcom-1642953249
…#22457) Co-authored-by: Jeremy Herve <[email protected]>
Fixes #22460.
This commit syncs r238742-wpcom.
In #22414, a couple of the changes switched to strict equality when the actual data compared had different types.
This meant that if a legacy widget was saved with visibility on a specific page, it would never show on that page (or any other page).
This was documented in Automattic/wp-calypso#60352 and Automattic/wp-calypso#60355
Changes proposed in this Pull Request:
Does this pull request change what data or activity we track or use?
Testing instructions: