Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Menu: remove role navigation attribute from nav item #22224

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Social Menu: remove role navigation attribute from nav item #22224

merged 1 commit into from
Jan 5, 2022

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 5, 2022

Changes proposed in this Pull Request:

This is no longer necessary. Read more about it here:
https://core.trac.wordpress.org/ticket/54054

According to HTML5 documentation, adding role="navigation" to a

element is unnecessary (and not permitted).

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Not much to test here, there should be no functional changes.

@jeherve
Social Menu: remove role navigation attribute from nav item
5c5d9e3 
This is no longer necessary. Read more about it here:
https://core.trac.wordpress.org/ticket/54054

> According to HTML5 documentation, adding role="navigation" to a <nav> element is unnecessary (and not permitted).
@jeherve jeherve added this to the jetpack/10.6 milestone Jan 5, 2022
@jeherve jeherve added [Focus] Accessibility Improving usability for all users (a11y) [Feature] Theme Tools [Pri] Low [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Jan 5, 2022
@jeherve jeherve self-assigned this Jan 5, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D72496-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jan 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: January 11, 2022.
  • Scheduled code freeze: January 3, 2022.

sdixon194
sdixon194 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@sdixon194 sdixon194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and smoke testing the social media links, which still work fine.

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 5, 2022
@jeherve jeherve merged commit d2f9c40 into master Jan 5, 2022
@jeherve jeherve deleted the update/social-menu-nav branch January 5, 2022 17:50
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

Great news! One last step: head over to your WordPress.com diff, D72496-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@jeherve
Copy link
Member Author

jeherve commented Jan 5, 2022

r237659-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdixon194 sdixon194 sdixon194 approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Theme Tools [Focus] Accessibility Improving usability for all users (a11y) [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
jetpack/10.6
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @matticbot @sdixon194