Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: update WordPress version requirements #21788

Merged
merged 5 commits into from
Dec 15, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Nov 17, 2021

Changes proposed in this Pull Request:

  • With the upcoming release of WordPress 5.9, our plugins will now require the previous version of WordPress, version 5.8.
  • Let's also update to reflect that we've tested our plugins with the upcoming version of WordPress.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Is CI happy?

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D70236-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve jeherve mentioned this pull request Nov 17, 2021
12 tasks
@github-actions github-actions bot added [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management labels Nov 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: January 11, 2022.
  • Scheduled code freeze: January 3, 2022.

Backup plugin:

  • Next scheduled release: January 4, 2022.
  • Scheduled code freeze: December 27, 2021.

Boost plugin:

  • Next scheduled release: January 31, 2022.
  • Scheduled code freeze: January 24, 2022.

@github-actions github-actions bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Nov 17, 2021
@jeherve jeherve requested a review from a team as a code owner November 17, 2021 18:22
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Nov 17, 2021
kraftbj
kraftbj previously approved these changes Nov 17, 2021
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! [Status] Blocked / Hold and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 17, 2021
@kraftbj
Copy link
Contributor

kraftbj commented Nov 18, 2021

5.9 will be delayed. https://make.wordpress.org/core/2021/11/17/wordpress-5-9-beta-1-delayed/

Let's see where they land with schedule and then decide if we merge this for 10.4 or the week-later-than-usual 10.5 January release.

@jeherve jeherve modified the milestones: jetpack/10.4, jetpack/10.5 Nov 22, 2021
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Blocked / Hold labels Dec 15, 2021
Copy link
Contributor

@sdixon194 sdixon194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI still happy

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 15, 2021
@jeherve jeherve merged commit 7a92c57 into master Dec 15, 2021
@jeherve jeherve deleted the update/wp-requirements-wp58 branch December 15, 2021 16:48
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D70236-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 15, 2021
@jeherve
Copy link
Member Author

jeherve commented Dec 15, 2021

r236660-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Block] VideoPress [Feature] Search For all things related to Search [Feature] WordPress.com Block Editor [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] BLOCKER [Tools] Development CLI The tools/cli to assist during JP development. Touches WP.com Files [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants