-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget visibility: Make request paths work on wpcom #20644
Conversation
This plugin checks the current REQUEST_URI to decide whether or not to register hooks. The REQUEST_URI it checked against was correct for WordPress.org sites but not for WordPress.com sites. These have now been updated to work in both cases.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
the wpcom code has been reviewed on D65394-code which hopefully counts as a team review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. 🚢
Part of #20057
This plugin checks the current REQUEST_URI to decide whether or not to
register hooks. The REQUEST_URI it checked against was correct for
WordPress.org sites but not for WordPress.com sites.
These have now been updated to work in both cases.
Builds on #20255 which doesn't work on wp.com simple sites, this has been discussed at p7DVsv-cqD-p2#comment-37158
Changes proposed in this Pull Request:
Made the URL check for when to register hooks weaker.
Jetpack product discussion
Testing instructions:
⚠ Note that this still won't work on wp.com unless changes to the eu-cookie-law plugin are applied too
What I expected
A button to control conditional widget visibility as part of the widget form
What happened instead
The widget form without widget visibility button
Does this pull request change what data or activity we track or use?
No.