Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget visibility: Make request paths work on wpcom #20644

Merged
merged 4 commits into from
Aug 25, 2021

Conversation

dsas
Copy link
Contributor

@dsas dsas commented Aug 11, 2021

Part of #20057

This plugin checks the current REQUEST_URI to decide whether or not to
register hooks. The REQUEST_URI it checked against was correct for
WordPress.org sites but not for WordPress.com sites.

These have now been updated to work in both cases.

Builds on #20255 which doesn't work on wp.com simple sites, this has been discussed at p7DVsv-cqD-p2#comment-37158

Changes proposed in this Pull Request:

Made the URL check for when to register hooks weaker.

Jetpack product discussion

Testing instructions:

  1. Create a wordpress.com simple site
  2. Click on Appearance then widgets in the right hand menu
  3. Add a legacy widget

Note that this still won't work on wp.com unless changes to the eu-cookie-law plugin are applied too

What I expected

A button to control conditional widget visibility as part of the widget form

image

What happened instead

The widget form without widget visibility button

Does this pull request change what data or activity we track or use?

No.

This plugin checks the current REQUEST_URI to decide whether or not to
register hooks. The REQUEST_URI it checked against was correct for
WordPress.org sites but not for WordPress.com sites.

These have now been updated to work in both cases.
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Widget Visibility labels Aug 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 11, 2021
@dsas dsas added [Status] Needs Team Review [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Aug 11, 2021
@dsas
Copy link
Contributor Author

dsas commented Aug 12, 2021

the wpcom code has been reviewed on D65394-code which hopefully counts as a team review :)

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 12, 2021
@jeherve jeherve added this to the jetpack/10.1 milestone Aug 12, 2021
@sdixon194 sdixon194 merged commit 79175ec into master Aug 25, 2021
@sdixon194 sdixon194 deleted the fix/widget-visibility-on-wpcom branch August 25, 2021 19:06
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widget Visibility [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants