Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting: Do pnpm install in Jetpack E2E dir before eslint #20333

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jul 12, 2021

Changes proposed in this Pull Request:

We don't include that as part of the workspace so normal development
doesn't need to install all of playwright and so on. But that also means
the root-level pnpm install doesn't process it, which can make eslint
be unable to resolve imports.

Jetpack product discussion

Came up in code review on #20326

Does this pull request change what data or activity we track or use?

No

Testing instructions:

We don't include that as part of the workspace so normal development
doesn't need to install all of playwright and so on. But that also means
the root-level `pnpm install` doesn't process it, which can make eslint
be unable to resolve imports.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Jul 12, 2021
@anomiex anomiex self-assigned this Jul 12, 2021
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jul 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 12, 2021
@kraftbj kraftbj merged commit f3badea into master Jul 12, 2021
@kraftbj kraftbj deleted the fix/linting-eslint-jetpack-e2e branch July 12, 2021 16:48
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants