-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Site Logo: add integer check for custom_logo #20049
Jetpack Site Logo: add integer check for custom_logo #20049
Conversation
Summary: Resolves 53517-gh-wp-calypso Code recently added to Gutenberg syncs site_logo options and custom_logo theme mod. This causes a conflict with the legacy Jetpack site logo functionality. This is an initial fix--we'll need to follow up to reconcile the new site_logo option and Jetpacks legacy logo functionality. Related convo: p1623174912090300-slack-CBTN58FTJ. Test Plan: - Sandbox a Simple Site - Activate a theme that uses `jetpack_the_site_logo` to display a logo, such as premium/soho (`wp theme activate premium/soho --url=[private link]`) - Navigate to the customizer, set a logo, and save the changes - Without this change, the logo does not display - With this change, the logo should display Reviewers: paulbunkham, kraftbj, fullofcaffeine, bernhardreiter Tags: #touches_jetpack_files Differential Revision: D62504-code This commit syncs r226957-wpcom.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
…affeine/r226957-wpcom-1623188698
Summary:
Resolves 53517-gh-wp-calypso and supports #19654
Implementation by @creativecoder.
Code recently added to Gutenberg syncs site_logo options and custom_logo theme mod. This causes a conflict with the legacy Jetpack site logo functionality.
This is an initial fix--we'll need to follow up to reconcile the new site_logo option and Jetpacks legacy logo functionality.
Related convo: p1623174912090300-slack-CBTN58FTJ.
Test Plan:
jetpack_the_site_logo
to display a logo, such as premium/soho (wp theme activate premium/soho --url=[private link]
)Reviewers: paulbunkham, kraftbj, fullofcaffeine, bernhardreiter
Tags: #touches_jetpack_files
Differential Revision: D62504-code
This commit syncs r226957-wpcom.
Fixes #
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: