Site Logo: 5.8 Compat

[kraftbj]

See #19654

Changes proposed in this Pull Request:

• Removes the transitionary code. Gutenberg now uses a site_logo option name.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D62502-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• 🔴 Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: July 6, 2021.
• Scheduled code freeze: June 28, 2021.

[kraftbj]

Removal may not be the right approach, but may want to use it to set it to match the new Core style. See p1623174912090300-slack-CBTN58FTJ

[pablinos]

I think we might need to keep some version of this code. If the theme changes to one that supports custom-logo then the code in core will not grab the ID from this Jetpack option. Also the site_logo option in core is expected to be an ID, so leaving the Jetpack one will mean that it's an array. We may want to check for an array being the option value and copy the ID to the custom_logo theme mod and the site_logo option.

Similarly we might need to handle conversion the other way.

[jeherve]

Would it make sense to move the get_option here?

Suggested change

	if ( current_theme_supports( 'custom-logo' ) && ! get_theme_mod( 'custom_logo' ) && get_option( 'site_logo' ) ) {
	$jp_logo = get_option( 'site_logo' );
	$jp_logo = get_option( 'site_logo' );
	if ( current_theme_supports( 'custom-logo' ) && ! get_theme_mod( 'custom_logo' ) && $jp_logo ) {

[kraftbj]

I thought about that, but didn't because it would mean a db call that might not be needed if current_theme_support was false.

[creativecoder]

Note, I modified and expanded some of the work here and created #20192.

It looks like we have quite a few themes still using the legacy site-logo functionality on WordPress.com, so it'll be important to get this in the next Jetpack release, since it's the final planned Jetpack release before WP 5.8.

[kraftbj]

Going to close this to defer to 20192.