Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Basic updates to prepare for WP 5.8 #20040

Merged
merged 5 commits into from
Jun 9, 2021
Merged

General: Basic updates to prepare for WP 5.8 #20040

merged 5 commits into from
Jun 9, 2021

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jun 8, 2021

See #19654

Changes proposed in this Pull Request:

  • Bump versions.
  • Remove Instagram code
  • More coming.

Jetpack product discussion

See 19654

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

  • Running WP 5.7 or 5.8, test an Instagram embed.

@kraftbj kraftbj added this to the jetpack/9.9 milestone Jun 8, 2021
@kraftbj kraftbj self-assigned this Jun 8, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D62495-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@kraftbj kraftbj mentioned this pull request Jun 8, 2021
Closed
20 tasks
@github-actions github-actions bot added [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Shortcodes / Embeds labels Jun 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Backup plugin:

  • Next scheduled release: July 6, 2021.
  • Scheduled code freeze: June 28, 2021.

Jetpack plugin:

  • Next scheduled release: July 6, 2021.
  • Scheduled code freeze: June 28, 2021.

@github-actions github-actions bot added [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management labels Jun 8, 2021
@kraftbj kraftbj requested review from jeherve, sdixon194 and samiff June 8, 2021 20:14
@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jun 8, 2021
@kraftbj kraftbj enabled auto-merge (squash) June 8, 2021 20:16
@kraftbj

This comment has been minimized.

Sign in to view
sdixon194
sdixon194 requested changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@sdixon194 sdixon194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I'm getting:

Deprecated: Jetpack::validate_sync_error_idc_option is deprecated since version jetpack-9.8! Use \Automattic\Jetpack\Identity_Crisis::validate_sync_error_idc_option instead. in /srv/users/user35ae9581/apps/user35ae9581/public/wp-includes/functions.php on line 4861

I think maybe from class-jetpack-redux-state-helper.php on line 79? 🤔

@sdixon194 sdixon194 added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 9, 2021
@kraftbj
Copy link
Contributor Author

kraftbj commented Jun 9, 2021 •
edited
Loading

Where are you seeing that @sdixon194? I'm not sure how this PR would be causing that. Fixing in 6bec462 but I think that's unrelated to this PR.

@sdixon194
Copy link
Contributor

Where are you seeing that @sdixon194? I'm not sure how this PR would be causing that.

Yeah that's why I'm confused too. I see the php error on any Jetpack dashboard - both locally and a JN site.

Screen Shot on 2021-06-09 at 15:58:04

Doing some more digging, it seems like it's also happening on Bleeding edge, so likely unrelated to this PR. It also doesn't happen on my regularly hosted test sites, just JN and locally 🤔

@kraftbj kraftbj requested a review from sdixon194 June 9, 2021 20:08
@kraftbj
Copy link
Contributor Author

kraftbj commented Jun 9, 2021

Well, this PR should be able to land once you can re-test it and we can slide the fix in here. LIkely caused by #19126.

@sdixon194 sdixon194 added the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 9, 2021
@kraftbj kraftbj merged commit 829ee26 into master Jun 9, 2021
@kraftbj kraftbj deleted the bump/to-5.7 branch June 9, 2021 20:25
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2021

Great news! One last step: head over to your WordPress.com diff, D62495-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 9, 2021
@kraftbj
Copy link
Contributor Author

kraftbj commented Jun 9, 2021

r227047-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdixon194 sdixon194 sdixon194 approved these changes

@jeherve jeherve Awaiting requested review from jeherve

@samiff samiff Awaiting requested review from samiff

Assignees

@kraftbj kraftbj

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Feature] Shortcodes / Embeds [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tools] Development CLI The tools/cli to assist during JP development. Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
jetpack/9.9
Development

Successfully merging this pull request may close these issues.
3 participants
@kraftbj @matticbot @sdixon194