Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: update colors to match upcoming WP 5.7 color changes #18916

Merged
merged 1 commit into from
Feb 25, 2021
Merged

General: update colors to match upcoming WP 5.7 color changes #18916

merged 1 commit into from
Feb 25, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 24, 2021 •
edited
Loading

Changes proposed in this Pull Request:

  • See https://core.trac.wordpress.org/ticket/49999
  • This excludes changes to the Atomic Admin Color Schemes feature.
  • That's a lot of color changes, but if I'm being honest I don't really notice the difference for most colors.
  • I'm marking this for the 9.6 milestone, so we can have time with these changes sitting in master for a while so we can spot any issues.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Since the changes are spread across many features, you'll need to check colors across all the dashboard.

Proposed changelog entry for your changes:

  • General: update colors to match upcoming color changes in WordPress 5.7.

@jeherve jeherve added this to the 9.6 milestone Feb 24, 2021
@jeherve jeherve self-assigned this Feb 24, 2021
@jeherve jeherve requested a review from a team as a code owner February 24, 2021 11:30
@matticbot matticbot added [Status] Needs Tracks Review Added/removed/modified a tracks event. Touches WP.com Files labels Feb 24, 2021
@jeherve jeherve mentioned this pull request Feb 24, 2021
Closed
11 tasks
@github-actions github-actions bot added [Block] Revue [Block] Social Previews [Package] Jitm [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Package Release This PR made changes to a package. Let's update that package now. Admin Page React-powered dashboard under the Jetpack menu [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Feature] Comment Likes [Feature] Contact Form [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Feature] Custom CSS [Feature] Extra Sidebar Widgets [Feature] Infinite Scroll [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Feature] Protect Also known as Brute Force Attack Protection [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Search For all things related to Search [Feature] Sharing Post sharing, sharing buttons [Feature] Shortcodes / Embeds [Feature] Theme Tools labels Feb 24, 2021
@jeherve jeherve requested a review from kraftbj as a code owner February 24, 2021 12:56
@jeherve jeherve added Plugin Search aka Feature Hints and removed Plugin Search labels Feb 24, 2021
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! and removed [Status] In Progress labels Feb 24, 2021
@jsnmoon
Copy link
Contributor

jsnmoon commented Feb 24, 2021

That's a lot of color changes, but if I'm being honest I don't really notice the difference for most colors.

Haha, agreed. The changes for Search are minimal, so this is good to go from our team's perspective 👍

kraftbj
kraftbj approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out a test site and confirmed the new colors are being used. I did not spot anything that requires additional work. Approving.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D57625-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve
Copy link
Member Author

jeherve commented Feb 25, 2021

I'll merge this now, to avoid having to rebase later on since it touches so many files.

@jeherve jeherve merged commit 12c1ec9 into master Feb 25, 2021
@jeherve jeherve deleted the update/colors-57 branch February 25, 2021 08:12
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 25, 2021
@jeherve
Copy link
Member Author

jeherve commented Feb 25, 2021

r221672-wpcom

@kraftbj
Copy link
Contributor

kraftbj commented Feb 25, 2021

thanks @jeherve. I meant circle up after the wpcom tests finished, but got pulled off. Thanks for bringing it across the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Block] Contact Form Form block (also see Contact Form label) [Block] Revue [Block] Story [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Feature] Comment Likes [Feature] Contact Form [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Feature] Custom CSS [Feature] Extra Sidebar Widgets [Feature] Infinite Scroll [Feature] Likes [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Feature] Protect Also known as Brute Force Attack Protection [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Related Posts [Feature] Search For all things related to Search [Feature] Sharing Post sharing, sharing buttons [Feature] Shortcodes / Embeds [Feature] SSO [Feature] Theme Tools [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Feature] VideoPress A feature to help you upload and insert videos on your site. [Feature] Widget Visibility [Package] Jitm [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Plugin Search aka Feature Hints [Status] Needs Design Review Design has been added. Needs a review! [Status] Needs Package Release This PR made changes to a package. Let's update that package now. [Status] Needs Tracks Review Added/removed/modified a tracks event. Touches WP.com Files
Projects
None yet
Milestone
jetpack/9.6
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @jsnmoon @matticbot @kraftbj @anomiex