Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wip) Extensions: organize blocks adding new categories #14721

Closed
wants to merge 2 commits into from

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Feb 18, 2020

Fixes #14598

Changes proposed in this Pull Request:

This PR reorganizes the block categories, adding/removing them.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Basically it changes the category for all blocks, but it doesn't affect the functionality of the blocks.

Testing instructions:

  • Apply these changes
  • Add/edit a post/page

You should be able to blocks organized by categories, according to the table described above.

image

@retrofox retrofox requested a review from a team February 18, 2020 18:25
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello retrofox! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39044-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Feb 18, 2020

Warnings
⚠️

pre-commit hook was skipped for one or more commits

⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against bd807f3

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Feb 18, 2020
@retrofox retrofox changed the title [wip] Extensions: organize blocks adding new categories Extensions: organize blocks adding new categories Feb 18, 2020
@retrofox retrofox changed the title Extensions: organize blocks adding new categories (wip) Extensions: organize blocks adding new categories Feb 18, 2020
@retrofox retrofox force-pushed the update/recategorize-blocks branch from 1dbfd15 to bd807f3 Compare February 18, 2020 22:33
@matticbot
Copy link
Contributor

retrofox, Your synced wpcom patch D39044-code has been updated.

@ockham
Copy link
Contributor

ockham commented Feb 19, 2020

Please consider registering a new Jetpack collection to hold these blocks -- see WordPress/gutenberg#17609 🙂

@retrofox
Copy link
Contributor Author

Please consider registering a new Jetpack collection to hold these blocks -- see WordPress/gutenberg#17609 🙂

👍 Thanks for the advice and reference.

@simison
Copy link
Member

simison commented Feb 19, 2020

Let's rather rebase and update #14454

@kraftbj
Copy link
Contributor

kraftbj commented Mar 3, 2020

Noting for the Jetpack collection, that is WordPress 5.4+, which is about to hit RC1. If we'll want to decide how we want to fallback for WP 5.3 (keep them all in a Jetpack category, use the new ones and lose the "Jetpack" category).

@kraftbj kraftbj deleted the update/recategorize-blocks branch April 6, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(3P) Update block categorization in CoBlocks
7 participants