Add the initial avatar action menu [...] #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinarol
added
enhance
pinarol
changed the title
pinarol
changed the title
|
 |
App Name |  Gravatar Prototype Build |
| Build Number | 1746 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 1513894 | |
| App Center Build | Gravatar SDK Demo - UIKit #394 |
etoledom
reviewed
Nov 21, 2024
Comment on lines
70
to
81
|
|
||
| @ViewBuilder | ||
| func ellipsisView() -> some View { | ||
| Image("more-horizontal", bundle: Bundle.module).renderingMode(.template) | ||
| .tint(.white) | ||
| .background(Color(uiColor: UIColor.gravatarBlack.withAlphaComponent(0.4))) | ||
| .cornerRadius(2) | ||
| .padding(CGFloat.DS.Padding.half) | ||
| } | ||
|
|
||
| @ViewBuilder | ||
| func actionsMenu() -> some View { |
There was a problem hiding this comment.
I believe @ViewBuilder attribute is not needed here
etoledom
reviewed
Nov 21, 2024
|
|
||
| @ViewBuilder | ||
| func ellipsisView() -> some View { | ||
| Image("more-horizontal", bundle: Bundle.module).renderingMode(.template) |
There was a problem hiding this comment.
As an alternative: We can set the rendering mode directly in the asset catalog.
That's good if the icon is always meant to be used this way.
There was a problem hiding this comment.
Right but asset catalogs are more fragile. It is easy to lose that setting if we change the icon. Setting it programmatically is safer.
etoledom
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #536
Description
Adds the menu with 2 sample items. At the moment the buttons don't do anything other than printing to the console.
Testing Steps
The avatars should have the ... menu, and 2 menu items should appear.