Deprecate ProfileViewConfiguration.avatarConfiguration.borderColor in favor of Palette.avatar.border
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in favor of `Palette.avatar.border
|
 |
App Name |  Gravatar Prototype Build |
| Build Number | 1706 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 5f6ffea | |
| App Center Build | Gravatar SDK Demo - UIKit #375 |
andrewdmontgomery
approved these changes
Nov 14, 2024
pinarol
deleted the
wppinar/deprecate-ProfileViewConfiguration.Avatar.borderColor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293
Description
We have a way to customize any color in the palette with
PaletteCustomizerwhich was introduced by #292. ProfileViewConfiguration's borderColor was made redundant. And now that I look back, this deprecation should have been included in that PR.One needs to do color customizations for both light/dark modes separately so ProfileViewConfiguration's borderColor wasn't best for the purpose anyway.
Testing Steps
CI green.