Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up SwiftLint removal #551

Merged

Conversation

andrewdmontgomery
Copy link
Contributor

@andrewdmontgomery andrewdmontgomery commented Oct 28, 2024

Closes #550

Description

This finishes removing SwiftLintPlugin by removing the unused dependency declaration.

It also apparently cleans up some inconsistencies with the Package.resolved files.

Testing Steps

  • CI should be 🟢

@andrewdmontgomery andrewdmontgomery changed the title Andrewdmontgomery/cleanup swiftlint removal Clean up SwiftLint removal Oct 28, 2024
@wpmobilebot
Copy link

Gravatar SwiftUI Prototype Build📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar SwiftUI Prototype Build Gravatar SwiftUI Prototype Build
Build Number1643
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-swiftui.prototype-build
Commit61e3d6e
App Center BuildGravatar SDK Demo - SwiftUI #336
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link

Gravatar UIKit Prototype Build📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar UIKit Prototype Build Gravatar UIKit Prototype Build
Build Number1643
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit61e3d6e
App Center BuildGravatar SDK Demo - UIKit #337
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Question:
Should we also remove the custom SwiftLint rule which checks the SDKLocalizedString usage? Or are we looking to use it in another way?

@andrewdmontgomery
Copy link
Contributor Author

Question:
Should we also remove the custom SwiftLint rule which checks the SDKLocalizedString usage? Or are we looking to use it in another way?

I'm looking for another way to use it. But good catch. I'll pull it for now.

@wpmobilebot
Copy link

Gravatar Prototype Build📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar Prototype Build Gravatar Prototype Build
Build Number1666
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commitd08442a
App Center BuildGravatar SDK Demo - UIKit #351
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@andrewdmontgomery andrewdmontgomery merged commit 17f08f5 into trunk Nov 1, 2024
9 checks passed
@andrewdmontgomery andrewdmontgomery deleted the andrewdmontgomery/cleanup-swiftlint-removal branch November 1, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up after SwiftLint removal
3 participants