-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up SwiftLint removal #551
Clean up SwiftLint removal #551
Conversation
📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Question:
Should we also remove the custom SwiftLint rule which checks the SDKLocalizedString
usage? Or are we looking to use it in another way?
I'm looking for another way to use it. But good catch. I'll pull it for now. |
📲 You can test the changes from this Pull Request in Gravatar Prototype Build by scanning the QR code below to install the corresponding build.
|
Closes #550
Description
This finishes removing SwiftLintPlugin by removing the unused dependency declaration.
It also apparently cleans up some inconsistencies with the Package.resolved files.
Testing Steps