Update to Xcode 16 #549
Merged
Update to Xcode 16 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinarol
reviewed
Oct 28, 2024
| @@ -65,6 +65,7 @@ class DefaultAvatarProvider: AvatarProviding { | |||
| private func applyCornerRadius() { | |||
| guard !skipStyling else { return } | |||
| avatarImageView.layer.cornerRadius = avatarCornerRadius | |||
| avatarImageView.layer.cornerCurve = .circular | |||
There was a problem hiding this comment.
Snapshots look nice as far as I can tell.
pinarol
approved these changes
Oct 28, 2024
|
 |
App Name |  Gravatar SwiftUI Prototype Build |
| Build Number | 1641 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-swiftui.prototype-build | |
| Commit | 49c2826 | |
| App Center Build | Gravatar SDK Demo - SwiftUI #335 |
|
 |
App Name |  Gravatar UIKit Prototype Build |
| Build Number | 1641 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 49c2826 | |
| App Center Build | Gravatar SDK Demo - UIKit #336 |
andrewdmontgomery
approved these changes
Oct 28, 2024
| @@ -3,6 +3,6 @@ | |||
| # This file is `source`'d before calling `buildkite-agent pipeline upload`, and can be used | |||
| # to set up some variables that will be interpolated in the `.yml` pipeline before uploading it. | |||
|
|
|||
| export IMAGE_ID=$(echo "xcode-$(cat .xcode-version)") | |||
| export IMAGE_ID="xcode-16.0-v7" | |||
Comment on lines
+10
to
+13
| override func invokeTest() { | ||
| withSnapshotTesting(record: .failed) { | ||
| super.invokeTest() | ||
| } |
There was a problem hiding this comment.
I didn't know about this
There was a problem hiding this comment.
This is new after updating the package.
If the snapshot comparison fails, there will be a new recording right away, but the test will also fail.
I think this is good to see right away what's de difference, and we can choose to save it (just run the test again it will succeed), or choose to make changes if the diff is unwanted.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #413
Description
This PR takes the work from #414, trying to fix the issue with circular corner radius on snapshot tests.
The way to fix this I found is to add this line on the Avatar view layer:
avatarImageView.layer.cornerCurve = .circularAnd it seems to work.
There are also small differences on how things are rendered, so mostly all snapshot need re-drawing (mostly fonts).
It's important to check that the differences are not noticeable by the eye.
Testing Steps