[Tooling] Setting up Danger #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
 |
App Name |  Gravatar SwiftUI Prototype Build |
| Build Number | 1637 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-swiftui.prototype-build | |
| Commit | d2c39f2 | |
| App Center Build | Gravatar SDK Demo - SwiftUI #333 |
|
 |
App Name |  Gravatar UIKit Prototype Build |
| Build Number | 1637 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | d2c39f2 | |
| App Center Build | Gravatar SDK Demo - UIKit #334 |
AliSoftware
reviewed
Oct 25, 2024
| github.dismiss_out_of_range_messages | ||
|
|
||
| # `files: []` forces rubocop to scan all files, not just the ones modified in the PR | ||
| # `skip_bundle_exec` prevents RuboCop from running using `bundle exec`, which we don't want on the linter agent |
There was a problem hiding this comment.
Unrelated to this PR, but now that the new standard is to use the linter agent for all repos that are using Dangermattic, I wonder if skip_bundle_exec: true shouldn't be the new default for this Dangermattic action 🤔
There was a problem hiding this comment.
This call is actually from danger-rubocop itself, but I agree, and this is something I remember thinking / discussing with someone else a while ago. files: [] can also be a default. Perhaps we can add in Dangermattic a helper or a patch to the Rubocop plugin adding these defaults.
Co-authored-by: Olivier Halligon <[email protected]>
|
We can close #533 after merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR setting up Danger and Dangermattic checks in the repo.
See pdnsEh-1TU-p2.
Testing Steps