Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: ExporterOptions.py #1042

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

BrandonPacewic
Copy link
Member

@BrandonPacewic BrandonPacewic commented Jul 24, 2024

Not much to say here, wrote some bad code, made it better. Functionality is unchanged, aside from the fact that readFromDesign will no longer throw exceptions when we update ExporterOptions and will now default to the individual field default.

@BrandonPacewic BrandonPacewic added exporter refactor The most important part of software development. labels Jul 24, 2024
@BrandonPacewic BrandonPacewic self-assigned this Jul 24, 2024
* dev:
  Types refactor
  PR suggestions for named inputs
  UI improvements, bug fixes, comments, and cleanup for named inputs
  lint fix and format
  Reset all inputs works and ejector + intake bindings
  Input saving and configuration fixes
  Create new custom input schemes that are assigned a random name
  Save and load named controls
  Input selection of default and custom named schemes
  Panel to pick a control scheme and brain configuration events
@BrandonPacewic BrandonPacewic marked this pull request as ready for review July 25, 2024 15:54
@BrandonPacewic BrandonPacewic requested review from PepperLola and azaleacolburn and removed request for a team July 25, 2024 15:54
Copy link
Member

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HunterBarclay HunterBarclay merged commit bf4cdb4 into dev Jul 25, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the branp/exporter-options-refactor branch July 25, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter refactor The most important part of software development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants