Cascading Shadows #1036
Cascading Shadows #1036
Conversation
Dhruv-0-Arora
added
the
ui/ux
Dhruv-0-Arora
requested review from
a-crowell and
LucaHaverty
and removed request for
a team
Co-authored-by: BrandonPacewic <[email protected]>
There was a problem hiding this comment.
Looking pretty good. I'd expand the configuration, either by making low and medium do different settings, or adding direct customization to the settings modal for the lighting. There are a number of artifacts in the shadows that will need to be addressed, but all in all, looking pretty good. Btw, the VSMSoftShadows look a bit better that the PCFSoftShadows. Might want to take a look at that.
| } | ||
|
|
||
| // setting light to cascading shadows | ||
| else if (quality === "High") { |
There was a problem hiding this comment.
| } | |
| // setting light to cascading shadows | |
| else if (quality === "High") { | |
| } else if (quality === "High") { // setting light to cascading shadows |
| } | ||
|
|
||
| // setting the shadow map size | ||
| const shadowMapSize = Math.min(4096, this._renderer.capabilities.maxTextureSize) |
There was a problem hiding this comment.
Maybe try using a smaller shadow map size for low quality to reduce memory usage. Cutting the max size from 4096 to 2048 can 1/4th the memory usage of the texture map.
| this._light.shadow.camera.right = shadowCamSize | ||
| this._light.shadow.mapSize = new THREE.Vector2(shadowMapSize, shadowMapSize) | ||
| this._light.shadow.blurSamples = 16 | ||
| this._light.shadow.bias = 0.0 |
There was a problem hiding this comment.
I would add in the normalBias again to fix the artifacts. Also see MirabufInstance about removing the offset of the shadow.
| @@ -149,8 +149,10 @@ class MirabufInstance { | |||
| opacity: opacity, | |||
| transparent: opacity < 1.0, | |||
There was a problem hiding this comment.
Use the shadowSide parameters to render against both the front and back faces when casting the shadow. This will remove the gap from the object to the shadow caused by the normal bias.
| parent: this._scene, | ||
| camera: this._mainCamera, | ||
| cascades: 3, | ||
| lightDirection: new THREE.Vector3(0.5, -0.5, 0.5).normalize(), | ||
| lightIntensity: 5, | ||
| shadowMapSize: shadowMapSize, | ||
| mode: "custom", | ||
| maxFar: 30, |
There was a problem hiding this comment.
Adding a shadow bias of -0.00001 worked pretty well for the closest cascade, but not so much for the others. I'd tinker with it.
|
@Dhruv-0-Arora When you've settled on the settings you like, could you grab comparisons of each different configuration, using a baseline of the current dev branch? Either that or the commit this branch was made from. |
Lowering the Shadow map created some problems with the shadows appearing on the ground so I decided to go back and keep the shadowmap at 4096. It also had minimal RAM usage |
Quality settings does work if you change between Low/Medium and High but the more refined version is in another PR |
|
Could you add a check to see if the quality settings are set to Ultra from a previous branch, and if so automatically correct them to 'high'? Mine were set to 'ultra' when I first loaded Synthesis and there were no shadows at all. |
Talked to Luca about this; we are just going to leave it for when I remove the low, medium, high dropdown in #1070 |
@HunterBarclay I could only see that from like a certain angle at around 30m away. One fix for this would be to increase the maxFar but that would make it so the higher res shadows will appear for a longer time. I added a commit that increases the number of cascades which kind of mitigates this |
|
Whenever I change the shadow quality or change tabs, the memory drops down to ~170mb with the 2018 field, then gradually increases before resetting again. Is this the same issue we were discussing before or something else? On dev I've been seeing a steady ~155mb with the same setup.
|
Yep thats the memory leak. If you build and then run then the memory leak won't happen so its a development env problem 😔 |
|
@LucaHaverty @Dhruv-0-Arora Actually, that cyclic increase is the garbage collector. The memory leak is a steady increase with no reset. |
Description
Cascading shadow implementation which increases the quality of the shadows. To change between the directional light and the CSM to increase fps, navigate to the settings modal and turn the quality to "low" or "medium" for the directional light.
Changes
Dev branch
Low Quality Shadows
High Quality Shadows
Cascaded Shadow Map from afar
JIRA Issue