Made requested changes

Autodesk · Jul 16, 2024 · cbcf154 · cbcf154
1 parent a489135
commit cbcf154
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/fission/src/mirabuf/MirabufSceneObject.ts b/fission/src/mirabuf/MirabufSceneObject.ts
@@ -112,7 +112,6 @@ class MirabufSceneObject extends SceneObject {
                     return
                 } else if (InputSystem.isKeyPressed("Escape")) {
                     // cancelling the creation of the mirabuf scene object
-                    this.DisableTransformControls()
                     World.SceneRenderer.RemoveSceneObject(this.id)
                     return
                 }
@@ -147,6 +146,7 @@ class MirabufSceneObject extends SceneObject {
     }
 
     public Dispose(): void {
+        this.DisableTransformControls()
         World.SimulationSystem.UnregisterMechanism(this._mechanism)
         World.PhysicsSystem.DestroyMechanism(this._mechanism)
         this._mirabufInstance.Dispose(World.SceneRenderer.scene)
@@ -216,6 +216,7 @@ class MirabufSceneObject extends SceneObject {
      * Changes the mode of the mirabuf object from being placed to being interacted with.
      */
     public DisableTransformControls(): void {
+        if (!this._transformGizmos) return
         this._transformGizmos?.RemoveGizmos()
         this._transformGizmos = undefined
         this.EnablePhysics()

diff --git a/fission/src/ui/modals/spawning/ManageAssembliesModal.tsx b/fission/src/ui/modals/spawning/ManageAssembliesModal.tsx
@@ -20,9 +20,7 @@ const AssemblyCard: React.FC<AssemblyCardProps> = ({ id, update }) => {
             <Label className="text-wrap break-all">{id}</Label>
             <Button
                 value="Delete"
-                // prettier-ignore
                 onClick={() => {
-                    (World.SceneRenderer.sceneObjects.get(id) as MirabufSceneObject).DisableTransformControls()
                     World.SceneRenderer.RemoveSceneObject(id)
                     update()
                 }}