fix(s3stream/wal): no need to create the file when checking dio #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ning Yu <[email protected]>
Signed-off-by: Ning Yu <[email protected]>
Chillax-0v0
requested review from
superhx,
SCNieh,
mooc9988 and
ShadowySpirits
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #934 +/- ##
============================================
- Coverage 55.92% 55.90% -0.03%
+ Complexity 1267 1265 -2
============================================
Files 133 133
Lines 8534 8534
Branches 789 789
============================================
- Hits 4773 4771 -2
Misses 3327 3327
- Partials 434 436 +2
|
superhx
approved these changes
Feb 20, 2024
| @@ -98,28 +98,28 @@ public static String checkAvailable(String path) { | |||
| return "java.nio.DirectByteBuffer.<init>(long, int) not available." + | |||
| " Add --add-opens=java.base/java.nio=ALL-UNNAMED and -Dio.netty.tryReflectionSetAccessible=true to JVM options may fix this."; | |||
| } | |||
| if (!path.startsWith(DEVICE_PREFIX) && !tryOpenFileWithDirectIO(String.format(CHECK_DIRECT_IO_AVAILABLE_FORMAT, path))) { | |||
| return "O_DIRECT not supported by the file system, path: " + path; | |||
| if (!path.startsWith(DEVICE_PREFIX)) { | |||
There was a problem hiding this comment.
建议用 file 命令而不是目录来判断块设备
There was a problem hiding this comment.
ok, will do it in next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.