Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): replace useless scheduler executor #663

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Nov 17, 2023

No description provided.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #663 (7afc73b) into main (2310863) will increase coverage by 0.62%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #663      +/-   ##
============================================
+ Coverage     58.99%   59.62%   +0.62%     
- Complexity     2139     2159      +20     
============================================
  Files           224      224              
  Lines         13860    13860              
  Branches       1285     1285              
============================================
+ Hits           8177     8264      +87     
+ Misses         5051     4934     -117     
- Partials        632      662      +30     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 58.17% <ø> (+3.37%) ⬆️
RocketMQ Proxy 42.62% <ø> (-0.13%) ⬇️
RocketMQ Store 77.71% <ø> (-0.10%) ⬇️
RocketMQ Stream 60.78% <100.00%> (-0.04%) ⬇️
RocketMQ Metadata 35.29% <ø> (ø)
Files Coverage Δ
.../src/main/java/com/automq/stream/s3/S3Storage.java 59.62% <100.00%> (ø)

... and 20 files with indirect coverage changes

Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@SCNieh SCNieh merged commit 53f9833 into main Nov 17, 2023
9 checks passed
@SCNieh SCNieh deleted the feat_replace_useless_schedule branch November 17, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants