Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement store metrics of topic/queue store-size and reserve-time #653

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

lizhanhui
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@lizhanhui lizhanhui enabled auto-merge (squash) November 16, 2023 11:07
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #653 (d247cc0) into main (1fc40ae) will increase coverage by 0.55%.
Report is 7 commits behind head on main.
The diff coverage is 30.05%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #653      +/-   ##
============================================
+ Coverage     58.50%   59.05%   +0.55%     
- Complexity     2063     2125      +62     
============================================
  Files           218      222       +4     
  Lines         13603    13778     +175     
  Branches       1247     1276      +29     
============================================
+ Hits           7958     8137     +179     
+ Misses         5019     4984      -35     
- Partials        626      657      +31     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (-0.05%) ⬇️
RocketMQ Controller 58.10% <14.28%> (+2.21%) ⬆️
RocketMQ Proxy 42.62% <ø> (+2.38%) ⬆️
RocketMQ Store 77.81% <ø> (+0.21%) ⬆️
RocketMQ Stream 59.57% <ø> (+0.04%) ⬆️
RocketMQ Metadata 35.29% <0.00%> (-0.39%) ⬇️
Files Coverage Δ
...mq/metadata/service/cache/S3StreamObjectCache.java 29.82% <ø> (ø)
...ontroller/server/store/impl/cache/StreamCache.java 95.45% <80.00%> (-4.55%) ⬇️
.../controller/server/store/DefaultMetadataStore.java 66.93% <0.00%> (+1.27%) ⬆️
...rocketmq/metadata/DefaultStoreMetadataService.java 30.57% <0.00%> (-0.52%) ⬇️
...a/com/automq/rocketmq/metadata/service/Helper.java 80.00% <80.00%> (ø)
...tmq/controller/server/store/impl/TopicManager.java 64.38% <0.00%> (-0.20%) ⬇️
...oller/server/store/impl/cache/AssignmentCache.java 77.77% <60.00%> (-2.23%) ⬇️
...tmq/metadata/service/DefaultS3MetadataService.java 67.54% <48.00%> (-1.78%) ⬇️
...ketmq/metadata/service/cache/S3WalObjectCache.java 43.75% <43.75%> (ø)
...rocketmq/metadata/service/cache/S3ObjectCache.java 17.94% <17.94%> (ø)
... and 1 more

... and 35 files with indirect coverage changes

Copy link

github-actions bot commented Nov 16, 2023

Qodana for JVM

3 new problems were found

Inspection name Severity Problems
Field can be local 🔶 Warning 2
Unnecessary modifier 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@lizhanhui lizhanhui merged commit 4ce8cd0 into main Nov 17, 2023
8 of 9 checks passed
@lizhanhui lizhanhui deleted the store_metrics branch November 17, 2023 02:28
SCNieh pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants