Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): fix the issue of some requests being suspended but never ending #651

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

ShadowySpirits
Copy link
Contributor

No description provided.

@ShadowySpirits ShadowySpirits enabled auto-merge (rebase) November 16, 2023 08:35
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #651 (05860cc) into main (3a696e8) will decrease coverage by 0.03%.
The diff coverage is 9.52%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #651      +/-   ##
============================================
- Coverage     59.10%   59.07%   -0.03%     
  Complexity     2100     2100              
============================================
  Files           218      218              
  Lines         13607    13616       +9     
  Branches       1248     1249       +1     
============================================
+ Hits           8042     8044       +2     
- Misses         4916     4920       +4     
- Partials        649      652       +3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 59.25% <ø> (ø)
RocketMQ Proxy 39.18% <9.52%> (-0.28%) ⬇️
RocketMQ Store 77.71% <ø> (ø)
RocketMQ Stream 59.60% <ø> (+0.05%) ⬆️
RocketMQ Metadata 35.67% <ø> (ø)
Files Coverage Δ
.../rocketmq/proxy/service/SuspendRequestService.java 58.58% <40.00%> (-0.79%) ⬇️
...umer/ExtendReceiveMessageResponseStreamWriter.java 0.00% <0.00%> (ø)
...etmq/proxy/processor/ExtendMessagingProcessor.java 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

auto-merge was automatically disabled November 16, 2023 10:21

Rebase merges are not allowed on this repository

@daniel-y daniel-y merged commit 63c3e38 into main Nov 16, 2023
7 of 9 checks passed
@daniel-y daniel-y deleted the add_timeout branch November 16, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants