Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): add node id to failover request #647

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Nov 16, 2023

@superhx superhx requested a review from Chillax-0v0 November 16, 2023 02:55
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #647 (3308350) into main (ce586e7) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #647      +/-   ##
============================================
+ Coverage     59.07%   59.13%   +0.06%     
- Complexity     2068     2087      +19     
============================================
  Files           217      218       +1     
  Lines         13541    13600      +59     
  Branches       1244     1247       +3     
============================================
+ Hits           7999     8043      +44     
- Misses         4889     4908      +19     
+ Partials        653      649       -4     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.85% <ø> (ø)
RocketMQ Controller 59.25% <ø> (ø)
RocketMQ Proxy 40.24% <ø> (ø)
RocketMQ Store 77.35% <ø> (+0.04%) ⬆️
RocketMQ Stream 59.55% <ø> (+0.13%) ⬆️
RocketMQ Metadata 35.67% <ø> (ø)
Files Coverage Δ
...com/automq/stream/s3/failover/FailoverRequest.java 0.00% <ø> (ø)
...java/com/automq/stream/s3/wal/BlockWALService.java 72.99% <ø> (-0.58%) ⬇️

... and 14 files with indirect coverage changes

Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@superhx superhx merged commit 09efaf5 into main Nov 16, 2023
9 checks passed
@superhx superhx deleted the change_failover_req branch November 16, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants